DataTrackStreamReadResponse has optional DataTrackStreamEOS field#130
Open
stephen-derosa wants to merge 6 commits into
Open
DataTrackStreamReadResponse has optional DataTrackStreamEOS field#130stephen-derosa wants to merge 6 commits into
stephen-derosa wants to merge 6 commits into
Conversation
stephen-derosa
requested review from
alan-george-lk and
xianshijing-lk
as code owners
stephen-derosa
force-pushed
the
sderosa/bugfix/BOT-347-DT-sub-unpub-race
branch
3 times, most recently
from
078b316 to
3b88682
Compare
Contributor
|
Rust PR has been merged: livekit/rust-sdks#1093 |
There was a problem hiding this comment.
Pull request overview
This PR addresses a race where a DataTrackStream can receive an EOS signal before the data-track event listener is fully ready by also propagating EOS via the immediate DataTrackStreamReadResponse.
Changes:
- Add handling of optional EOS info returned directly in
DataTrackStream::read()responses. - Factor EOS-to-terminal-error conversion into a helper used by both event-driven and read-response paths.
- Add unit tests covering EOS delivered via
DataTrackStreamReadResponse(both normal EOS and subscribe-failure EOS).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/data_track_stream.cpp | Handles optional EOS embedded in the synchronous read response and refactors EOS error extraction. |
| include/livekit/data_track_stream.h | Adds a forward declaration and private helper for read-response processing. |
| src/tests/unit/test_data_track_stream.cpp | Adds unit tests validating EOS behavior via read responses. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stephen-derosa
force-pushed
the
sderosa/bugfix/BOT-347-DT-sub-unpub-race
branch
2 times, most recently
from
485660c to
114cf3c
Compare
stephen-derosa
force-pushed
the
sderosa/bugfix/BOT-347-DT-sub-unpub-race
branch
from
9ca29b4 to
6d521a7
Compare
xianshijing-lk
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
resolves BOT-347
fixes race condition of client SDK receiving eos events and initializing DT event listener by floating up an optional EOS message for a
DataTrackStreamReadResponse